Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get transactions CLI for Clawback #15541

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix get transactions CLI for Clawback #15541

merged 1 commit into from
Jun 16, 2023

Conversation

ytx1991
Copy link
Contributor

@ytx1991 ytx1991 commented Jun 15, 2023

Purpose:

Fix the get transactions CLI while the wallet is not fully synced and the coin record for Clawback transactions is missing.

Current Behavior:

Throw exception

New Behavior:

Skip the clawback transactions

Testing Notes:

CLI

@ytx1991 ytx1991 added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 15, 2023
@ytx1991 ytx1991 requested review from trepca and paninaro June 15, 2023 22:20
@ytx1991 ytx1991 requested a review from a team as a code owner June 15, 2023 22:20
@ytx1991 ytx1991 changed the base branch from main to release/1.8.2 June 15, 2023 22:21
trepca
trepca approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@trepca trepca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not seeing the error anymore

@wallentx wallentx merged commit bde6f39 into release/1.8.2 Jun 16, 2023
@wallentx wallentx deleted the get_tx_fix branch June 16, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trepca trepca trepca approved these changes

@paninaro paninaro Awaiting requested review from paninaro

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ytx1991 @trepca @wallentx